On Sat, Jul 05, 2014 at 04:00:55PM -0400, Tejun Heo wrote:
> If we switch to using a qcflag for marking internal commands, it
> probably would be better to guarantee that EH commands always use tag
> 0.
Do you mean we add a WARN_ON_ONCE() to check the tag in ata_tag_internal()?
> > + ATA_QCFLAG_INTERNAL = (1 << 19), /* Internal command */
>
> Let's make it more explicit - ATA_QCFLAG_EH.
Sure.
>
> > +static inline unsigned int ata_tag_internal(struct ata_queued_cmd *qc)
> > +{
> > + return (qc->flags & ATA_QCFLAG_INTERNAL);
> > +}
>
> As we're changing the interface anyway, ata_qc_eh()?
Sounds good, will change.
> So, yeah, I like the proposed changes. This is a bit too much as a
> fix for fsl tho. First fix fsl and then update so that we use the
> qcflag in the devel branch?
OK, will do.
Thanks,
Kevin
Attachment:
pgp3PazZgzc9H.pgp
Description: PGP signature
