On Thu, Jul 03, 2014 at 08:09:41PM +0800, Kevin Hao wrote: > The sata on fsl mpc8315e is broken after the commit 8a4aeec8d2d6 > ("libata/ahci: accommodate tag ordered controllers"). The reason is > that the ata controller on this SoC only implement a queue depth of > 16. When issuing the commands in tag order, all the commands in tag > 16 ~ 17 are mapped to tag 0 unconditionally and then causes the sata Shouldn't the function at least trigger WARN_ON_ONCE() if it's forcing the tag to be 0 when it shouldn't be? Silently mapping things to zero doesn't look like a particularly good idea. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html