Hello, On Wed, Jul 02, 2014 at 03:45:07PM +0530, Suman Tripathi wrote: > +int ahci_restart_engine(struct ata_port *ap) > +{ > + struct ahci_host_priv *hpriv = ap->host->private_data; > + > + ahci_stop_engine(ap); > + ahci_start_fis_rx(ap); > + hpriv->start_engine(ap); > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(ahci_restart_engine); I don't get this function. No other ahci needs it and it's not even contained libahci proper. It calls back to the calling low level driver. Why not just expose ahci_start_fis_rx() and implement the above in xgene? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html