On Thu, Jul 03, 2014 at 09:50:58AM -0400, Tejun Heo wrote:
> On Thu, Jul 03, 2014 at 08:09:41PM +0800, Kevin Hao wrote:
> > The sata on fsl mpc8315e is broken after the commit 8a4aeec8d2d6
> > ("libata/ahci: accommodate tag ordered controllers"). The reason is
> > that the ata controller on this SoC only implement a queue depth of
> > 16. When issuing the commands in tag order, all the commands in tag
> > 16 ~ 17 are mapped to tag 0 unconditionally and then causes the sata
>
> Shouldn't the function at least trigger WARN_ON_ONCE() if it's forcing
> the tag to be 0 when it shouldn't be? Silently mapping things to zero
> doesn't look like a particularly good idea.
Indeed. I will add a WARN_ON_ONCE() in the fsl sata driver.
Thanks,
Kevin
Attachment:
pgp0cEIQEmYZd.pgp
Description: PGP signature
