Hello, Kevin. On Fri, Jul 04, 2014 at 02:46:46PM +0800, Kevin Hao wrote: > Since the fsl sata only support a 16 command queue, if we put the internal > command to ata_port->qcmd[16 - 1], we can easily change the above code to: Hmmm... something that I wanna do is using all 32 tags for regular commands and moving ATA_TAG_INTERNAL to something out-of-bounds, say 32 or INT_MAX and let each driver use whatever command slot (most likely zero) to actually execute internal commands. There really is no reason to permanently reserve a command tag for internal commands like we do now; however, it could be that using a tag number to distinguish an internal command isn't a very good idea to begin with and it could be better to use a qcflag instead. Anyways, sata_fsl already has workaround for ATA_TAG_INTERNAL, right? Given that the situation around internal tag handling may change, I'm not sure about changing the interface now. Is it a lot of cruft on fsl side? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
