Hello, Kevin.
On Sat, Jul 05, 2014 at 09:21:34PM +0800, Kevin Hao wrote:
> @@ -1570,15 +1572,8 @@ unsigned ata_exec_internal_sg(struct ata_device *dev,
...
> + /* Tag 0 is used as some drivers choke if any other tag is given. */
> + tag = 0;
If we switch to using a qcflag for marking internal commands, it
probably would be better to guarantee that EH commands always use tag
0.
> diff --git a/include/linux/libata.h b/include/linux/libata.h
> index 5ab4e3a76721..74612875b198 100644
> --- a/include/linux/libata.h
> +++ b/include/linux/libata.h
> @@ -265,6 +265,7 @@ enum {
> ATA_QCFLAG_FAILED = (1 << 16), /* cmd failed and is owned by EH */
> ATA_QCFLAG_SENSE_VALID = (1 << 17), /* sense data valid */
> ATA_QCFLAG_EH_SCHEDULED = (1 << 18), /* EH scheduled (obsolete) */
> + ATA_QCFLAG_INTERNAL = (1 << 19), /* Internal command */
Let's make it more explicit - ATA_QCFLAG_EH.
> +static inline unsigned int ata_tag_internal(struct ata_queued_cmd *qc)
> +{
> + return (qc->flags & ATA_QCFLAG_INTERNAL);
> +}
As we're changing the interface anyway, ata_qc_eh()?
> > Anyways, sata_fsl already has workaround for ATA_TAG_INTERNAL, right?
>
> Yes, the internal command is mapped to tag 0 in sata_fsl.
>
> > Given that the situation around internal tag handling may change, I'm
> > not sure about changing the interface now. Is it a lot of cruft on
> > fsl side?
>
> Yes, I agree.
So, yeah, I like the proposed changes. This is a bit too much as a
fix for fsl tho. First fix fsl and then update so that we use the
qcflag in the devel branch?
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
