On Tuesday, December 31, 2013 8:34 PM, Tejun Heo wrote: > On Tue, Dec 31, 2013 at 10:59:13AM +0530, Sachin Kamat wrote: > > plat/regs-ata.h is used only by Samsung PATA driver. > > Move this file to the drivers folder to remove platform > > dependency required for multiplatform support. > > > > Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> > > Applied to libata/for-3.14. > > As this is only used by pata_samsung_cf.c, can you please follow up > with a patch to roll pata_samsung_cf.h into .c? There's no point in > creating separate header files for stuff which isn't shared among > multiple files. (+cc Brian Norris, linux-mtd mailing list) Right, I also agree with Tejun's opinion. Would you also send the patch to roll .h into .c for your another patch "mtd: s3c2410: Move plat/regs-nand.h to drivers/mtd"? (http://www.spinics.net/lists/linux-samsung-soc/msg25498.html) Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
