Tejun Heo wrote: > > On Tue, Dec 31, 2013 at 10:59:13AM +0530, Sachin Kamat wrote: > > plat/regs-ata.h is used only by Samsung PATA driver. > > Move this file to the drivers folder to remove platform > > dependency required for multiplatform support. > > > > Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> > > Applied to libata/for-3.14. > > As this is only used by pata_samsung_cf.c, can you please follow up > with a patch to roll pata_samsung_cf.h into .c? There's no point in > creating separate header files for stuff which isn't shared among > multiple files. > Oops, I read this just now ;-) Tejun, if you've applied this in your tree already, I'm OK so please kindly ignore my previous reply. Sachin, when you move the definitions into the .c file per Tejun's suggestion, please cleanup useless definitions. Thanks and happy new year. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
