On Tue, Jun 18, 2013 at 02:19:52AM +0000, Zhu Richard-R65037 wrote:
> Hi Tejun&Shawn:
> Thanks for your comments.
>
> Hi Tejun:
> I looked through the for-next branch of the libata git-repo, there maybe a merge conflict.
> "
> static const struct of_device_id ahci_of_match[] = {
> { .compatible = "snps,spear-ahci", },
> { .compatible = "snps,exynos5440-ahci", },
This is exactly what I'm concerned about. We will end up with a huge
match table with all different platform specific compatible strings in
there. But they're all matching to the same programming model of the
same IP block. That's not how device tree compatible table works.
> {},
> };
> MODULE_DEVICE_TABLE(of, ahci_of_match);
> "
>
> How about to re-change the patch, based on for-next branch of the libata git-repo.
>
Yes, I think the driver part and platform part can go separately.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
