On Mon, Jun 17, 2013 at 05:52:46PM +0800, Richard Zhu wrote: > imx6q contains the Synopsys AHCI SATA controller which shares > ahci_platform driver with other controllers. > > This patch updates the DT compatible list for ahci_platform, > and enable the imx6q ahci sata support. > > Signed-off-by: Richard Zhu <r65037@xxxxxxxxxxxxx> > --- > drivers/ata/ahci_platform.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c > index 7a8a284..61f2142 100644 > --- a/drivers/ata/ahci_platform.c > +++ b/drivers/ata/ahci_platform.c > @@ -327,6 +327,7 @@ static SIMPLE_DEV_PM_OPS(ahci_pm_ops, ahci_suspend, ahci_resume); > > static const struct of_device_id ahci_of_match[] = { > { .compatible = "snps,spear-ahci", }, > + { .compatible = "snps,imx-ahci", }, I'm not sure it makes much sense to invent multiple platform specific strings for an IP which is completely compatible between them. Why don't we just have a generic compatible string like "snps,ahci" for all those compatible platforms, and only add platform specific string when there is incompatibility on particular platform to deal with? Added devicetree-discuss to get DT people's opinion. Shawn > {}, > }; > MODULE_DEVICE_TABLE(of, ahci_of_match); > -- > 1.7.5.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html