2011/2/15 Tejun Heo <tj@xxxxxxxxxx>: > On Tue, Feb 15, 2011 at 06:26:21PM +0800, Lin Mac wrote: >> 2011/2/15 Tejun Heo <tj@xxxxxxxxxx>: >> > On Tue, Feb 15, 2011 at 05:50:55PM +0800, Lin Mac wrote: >> >> > You're already working around buggy hardware. It isn't surprising >> >> > that both behave incorrectly in their own separate ways. Just do >> >> > what's necessary to get the hardware working as long as the workaround >> >> > is localized to the specific controller. >> >> >> >> If I implement it as a quirk, would you prefer to add a new field >> >> quirk, or just use flags of ahci_host_priv and add a new AHCI_HFLAG*? >> >> I prefer the later, but afraid that it's not what it is for. >> > >> > Please implement it as a separate ata_port_operations like >> > ahci_CONTROLLER_NAME_ops and use the customized reset methods. >> >> In fact, I did. But it doesn't get accepted. >> >> [PATCH v5 0/3] add CNS3xxx AHCI support (Cavium Networks) >> http://www.spinics.net/lists/linux-ide/msg39859.html >> >> And given that there are many of them, shouldn't we implement it as quirk? > > IIRC, the rejected part was the renaming of files and addition of a > new driver, no? Before v5, Jeff's concern is the renaming of the ahci_platform.c. Therefore I fixed that part and rename the module name instead. In v5, first I rename the module ahci_platform to ahci_platforms. Then switch the ahci platform driver to device table matching. And add cns3xxx change with a new entry in device table. Basheer suggest that several platform have this issue, and can be implemented as quirk. Hi guys, could you kindly provide some input on the patchset: [PATCH v5 0/3] add CNS3xxx AHCI support (Cavium Networks) http://www.spinics.net/lists/linux-ide/msg39859.html Best Regards, Mac Lin -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
