2011/2/15 Tejun Heo <tj@xxxxxxxxxx>:
> On Tue, Feb 15, 2011 at 05:50:55PM +0800, Lin Mac wrote:
>> > You're already working around buggy hardware. It isn't surprising
>> > that both behave incorrectly in their own separate ways. Just do
>> > what's necessary to get the hardware working as long as the workaround
>> > is localized to the specific controller.
>>
>> If I implement it as a quirk, would you prefer to add a new field
>> quirk, or just use flags of ahci_host_priv and add a new AHCI_HFLAG*?
>> I prefer the later, but afraid that it's not what it is for.
>
> Please implement it as a separate ata_port_operations like
> ahci_CONTROLLER_NAME_ops and use the customized reset methods.
In fact, I did. But it doesn't get accepted.
[PATCH v5 0/3] add CNS3xxx AHCI support (Cavium Networks)
http://www.spinics.net/lists/linux-ide/msg39859.html
And given that there are many of them, shouldn't we implement it as quirk?
AHCI support Port Multiplier problem. (Faraday)
http://www.spinics.net/lists/linux-ide/msg39815.html
Texas Instruments OMAP L138
ATI SB600/SB700 (ahci_sb600_softreset)
http://kerneltrap.org/mailarchive/git-commits-head/2008/6/14/2122314
Best Regards,
Mac Lin
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
