Alan Cox wrote: >> With the attached patch, you can use ->flags for the two new flags, and >> you can set those bits in the driver where you set the other >> ATA_FLAG_xxx bits. > > Its half way but I realised there is another reason that doesn't work > (and indeed why the device private flags are asking for trouble) > > What are the locking sematics for ap->flags ? ap->flags is owned by EH context and only EH can change it. ap->pflags is for dynamic flags and can be changed under port lock by anyone but I forgot why I named that pflags instead of dflags. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
