On Thu, 09 Apr 2009 08:50:10 -0400 Jeff Garzik <jeff@xxxxxxxxxx> wrote: > Alan Cox wrote: > > Something like this then ? > > > > > > The legacy old IDE API for this is a bit primitive so we try and map stuff > > sensibly onto it. > > > > - Add flags2 as we ran out of flags > > - Set PIO over DMA devices to report 32bit > > - Add ability to change the PIO32 settings if the controller permits it > > - Add that functionality into the sff drivers > > - Add that functionality into the VLB legacy driver > > - Turn on the 32bit PIO on the ninja32 and add support there > > > > Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx> > > I think the flag2 stuff needs a closer look WRT driver setup, but > overall looks good. > > Consider it ACK'd, if I cannot come up with anything better for flags2 The alternative would be to remove the private 8 flags from flags but that means fairly excessive changes to all the devices [Looks smug and notes that he pointed out that driver private flags in the same field would turn out to be a bad idea early on ...] -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
