> > What are the locking sematics for ap->flags ? > > In general, for both driver-private flags and ATA_FLAG_xxx, the flags > should be set at compile or pci_driver::probe() time, and never touched > after that. Ok we should document that. > > So your patch is a bit of abuse, really, by fiddling with ap->flags at > all ;-) The drivers, for example, never touch the driver-private flags > after they are set at init. The core will occasionally twiddle flags, > inside of spin_lock_irqsave(ap->lock) Which is the lock I am using > Thus 'set' has always been an illusion for libata. It's really been > read-only. Which nicely solves the flags2 problem - we have flags, and we have dynamic flags and if we move the other changing flags into dynflags over time all will be happy. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
