kristen.c.accardi@xxxxxxxxx wrote:
If the port isn't either a drive bay or an external SATA port,
mark the port not-hotpluggable.
That's just flat out incorrect, though.
We've been hotplugging SATA cables since SATA began, when the _most
common_ hotplug case was where a port was neither a drive bay nor eSATA.
Part of the beauty of SATA is being able to just 'yank the cable'.
PORT_CMD_ESP and PORT_CMD_HPCP are positive indicators of hotplug
capability, but are not exclusively such.
So, this patch would create regressions for people in servers or
desktops or development systems that wish to retain their _existing_
ability to hotplug.
One guaranteed way to avoid regressions is to default ahci_power_save to
zero, but that's then not helpful to Linux users in general, few of
which will know of this module option and turn it on.
This is actually wandering into system-wide power policy :/
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
