On Thu, 08 May 2008 11:35:11 -0400, Jeff Garzik <jeff@xxxxxxxxxx> wrote: > Markus Trippelsdorf wrote: > >> Tejun Heo (12): > >> libata: improve post-reset device ready test > > > > This commit (78ab88f04f44bed566d51dce0c7cbfeff6449a06) causes a long > > boot delay with my onboard Promise controller. It seems like libata > > probes for a nonexisting PATA drive... > > I also had this patch collected from LKML, that still applies to -git6. Is it really needed ? ref: http://marc.info/?l=linux-ide&m=120913178617926&w=2 TIA --- upstream/drivers/ata/libata-eh.c 2008-04-30 17:35:36.000000000 -0400 +++ linux/drivers/ata/libata-eh.c 2008-04-30 17:35:45.000000000 -0400 @@ -1312,8 +1312,7 @@ err_mask |= AC_ERR_ATA_BUS; action |= ATA_EH_RESET; } - if (serror & - (SERR_DATA_RECOVERED | SERR_COMM_RECOVERED | SERR_DATA)) { + if (serror & (SERR_DATA_RECOVERED | SERR_DATA)) { err_mask |= AC_ERR_ATA_BUS; action |= ATA_EH_RESET; } @@ -1924,7 +1923,7 @@ } if (ehc->i.serror) - ata_port_printk(ap, KERN_ERR, + ata_link_printk(link, KERN_ERR, "SError: { %s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s}\n", ehc->i.serror & SERR_DATA_RECOVERED ? "RecovData " : "", ehc->i.serror & SERR_COMM_RECOVERED ? "RecovComm " : "", -- J.A. Magallon <jamagallon()ono!com> \ Software is like sex: \ It's better when it's free Mandriva Linux release 2008.1 (Cooker) for i586 Linux 2.6.23-jam05 (gcc 4.2.2 20071128 (4.2.2-2mdv2008.1)) SMP PREEMPT -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
