On Thursday 08 May 2008, Russell King wrote: > On Wed, May 07, 2008 at 07:43:24PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Always call SELECT_MASK(..., 0) in ide_tf_load() (needs to be done > > to match ide_set_irq(..., 1)) and then remove IDE_TFLAG_NO_SELECT_MASK > > taskfile flag. > > > > This change should only affect hpt366 and icside host drivers since > > ->maskproc(..., 0) for sgiioc4 is equivalent to ide_set_irq(..., 1). > > Provided the two channels on icside are serialised (so IDE doesn't > try to enable IRQs on both channels at the same time) it shouldn't > be a problem. Yep, they are serialized. > However, since I don't use this driver anymore (using the PATA version > instead) I don't feel it's right for me to ack this change. Thanks for taking a look anyway. Bart -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
