Hello. Alek Du wrote:
NAK this patch completely -- both libata and IDE parts.
In the future it would be worth to post 2 separate patches, one for IDE and one for libata -- since they should go thru the different maintainer trees.
Luckily, I have just had a quick look at the datasheet to which you've linked and that was enough to conclude that SCH is *not* compatible to ICH/PIIX family, so absolutely needs a separate driver!
Most registers are same
Well, if you mean the standard BMDMA and standard PCI config. space registers (0x00 thru 0x3f), then those are mostly the same for the majority of the PCI IDE controllers. Why not stick your code into one of the other driver instead? ;-)
except for port enable bit, IOCFG and DMA timing. Now
And also PIO and UDMA timings/enable. Actually, all the vendor-specific PCI config. registers are different from PIIX/ICH -- and that's what makes the PATA drivers different from each other.
I know why my patch just works -- the BIOS set the timing correctly.
Yeah, and we have the special drivers which rely on the BIOS doing all the mode programming...
Thanks for point this out. I will post a separate driver patch later.
In the meantwhile the only viable solution would be to stick your code into drivers/ide/pci/generic.c and drivers/ata/ata_generic.c. No more hacks, please. :-)
Thanks, Alek
MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
