Dear Tejun, > sam song wrote: > > Still one puzzle to consult with you. As you mentioned, the ATA Pass Thru in > > SELS10 2.6.16.21-0.8 is "broken". So what is the workable vanilla kernel > > besides 2.6.23.X? I > > need to have more choice on distribution. For example 2.6.18.X vanilla > > kernel with your patch can work? > > Well. libata has been developing pretty fast. I think post 2.6.20 > should be fine but not too sure. Does anyone remember better? Until now, I have confirmed that the following kernel can support the special long time command after applied your patch in block/scsi_ioctl.c. RHEL4.5 - 2.6.9-55 RHEL5 - 2.6.18-8 Vanilla kernel 2.6.23 I saw your patch in the main tree already. Actually, the key change workable for me is the following piece - timeout only. diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c index 91c7322..9675b34 100644 --- a/block/scsi_ioctl.c +++ b/block/scsi_ioctl.c @@ -230,7 +230,7 @@ static int blk_fill_sghdr_rq(struct request_queue *q, struct request *rq, rq->cmd_len = hdr->cmd_len; rq->cmd_type = REQ_TYPE_BLOCK_PC; - rq->timeout = (hdr->timeout * HZ) / 1000; + rq->timeout = msecs_to_jiffies(hdr->timeout); if (!rq->timeout) rq->timeout = q->sg_timeout; if (!rq->timeout) FYI. Thanks, Sam Song -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
