Jeff Garzik wrote: > Jeff Garzik wrote: >> Tejun Heo wrote: >>> xfer_mask is unsigned int not unsigned long. Change ->mode_filter to >>> take and return unsigned int. >>> >>> While at it, rename @adev of ata_pci_default_filter() to @dev for >>> consistency. >>> >>> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> >>> --- >>> drivers/ata/libata-sff.c | 5 +++-- >>> drivers/ata/pata_acpi.c | 2 +- >>> drivers/ata/pata_ali.c | 2 +- >>> drivers/ata/pata_hpt366.c | 2 +- >>> drivers/ata/pata_hpt37x.c | 4 ++-- >>> drivers/ata/pata_pdc2027x.c | 4 ++-- >>> drivers/ata/pata_scc.c | 2 +- >>> drivers/ata/pata_serverworks.c | 4 ++-- >>> include/linux/libata.h | 5 +++-- >>> 9 files changed, 16 insertions(+), 14 deletions(-) >> >> as I noted I permit unsigned long, which is a naturally aligned >> machine int on our platforms. > > er, s/permit/prefer/ Alright. I don't agree but don't have much problem either. Will update them the other way. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html