Jeff Garzik wrote: > Tejun Heo wrote: >> ata_acpi_gtm_xfermask() as separated out from pacpi_discover_modes() >> has various bugs. Fix them. >> >> * The wrong comparison operator is used when finding for matching >> cycle resulting totally bogus result. >> >> * With the comparion operator fixed, boundary condtion handling is >> clumsy. >> >> * Setting of any DMA mask bit set all bits in PIO mask. >> >> * MWDMA and UDMA blocks are swapped. > > shouldn't this be combined with patch #6? I did it that way at first but that made the patch difficult to review because the content changes (bug fixes) are hidden by moving whole function from pata_acpi to libata-acpi, so I separated out the fix part into this patch. Thanks. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
