Re: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Kuan Luo wrote:
One idea, only simply adding if (!swncq_enabled) nv_port_info[SWNCQ].flags &= ~ATA_FLAG_NCQ;
	
	ppi[0] = &nv_port_info[type];
	rc = ata_pci_prepare_sff_host(pdev, ppi, &host);

I don't know if this is appropriate


As long as the structure is not read-only ('const'), that is OK.

And just for future reference, make sure you're aware of the implications of this applying to all sata_nv-aware PCI IDs. If you present multiple SATA devices on a PCI bus, or have multiple PCI cards (rare in NV's case, I guess) the probe function will be called multiple times. You might even want to put that code into the module init function, rather than the probe function.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux