hi, i saw the below changes from http://git.kernel.org/?p=linux/kernel/git/jgarzik/libata-dev.git;a=commi tdiff;h=5a5a9e1890b8260686218a68862d880daee1a817 [libata] sata_nv: Clean up ATA_FLAG_NCQ usage; bit test micro-opt @@ -622,7 +622,9 @@ static const struct ata_port_info nv_port_info[] = { /* SWNCQ */ { .sht = &nv_swncq_sht, - .flags = ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY, + .flags = ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY | + ATA_FLAG_NCQ, + .link_flags = ATA_LFLAG_HRST_TO_RESUME, .pio_mask = NV_PIO_MASK, .mwdma_mask = NV_MWDMA_MASK, .udma_mask = NV_UDMA_MASK, If swncq_enabled is set zero by user, nv_swncq_host_init would not be called . Then ncq should be disabled and the libata shouldn't send ncq cmd. I am not sure whether the ATA_FLAG_NCQ flag which is in default set makes libata send ncq cmd even when swncq_enable is 0? nv_init_one } else if (type == SWNCQ && swncq_enabled) { dev_printk(KERN_NOTICE, &pdev->dev, "Using SWNCQ mode\n"); nv_swncq_host_init(host); } ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
