Tejun Heo wrote:
> Hello,
>
>
>>+void ata_irq_on(struct ata_port *ap)
>> {
>> struct ata_ioports *ioaddr = &ap->ioaddr;
>>- u8 tmp;
>>
>> ap->ctl &= ~ATA_NIEN;
>> ap->last_ctl = ap->ctl;
>>
>> iowrite8(ap->ctl, ioaddr->ctl_addr);
>>- tmp = ata_wait_idle(ap);
>>+ ata_wait_idle(ap);
>>
>> ap->ops->irq_clear(ap);
>>-
>>- return tmp;
>> }
>
>
> Missing ata_chk_status() before clearing ATA_NIEN seems a bit dangerous
> to me.
>
Will fix it in next revision. Thanks for the advice.
--
albert
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
