(Revised per Tejun's advice.) For ATA, there are two levels of mechanism available to turn irq on/off. - device level: nIEN bit in the control register. This masks INTRQ from the device. - host adapter level: some controllers can mask out per-port irq from the host adapter. Currently various parts of libata deal with irq on/off. ex. tf_load() can alter the nIEN bit. ex. irq_on() also alters the device level nIEN bit. ex. freeze()/thaw() deal with the host adapter irq mask. It seems these irq_on/off codes could be better structured. Patches against the libata-dev tree for your review, thanks. 1/7: remove irq_on from ata_bus_reset() and ata_std_postreset() 2/7: sata_promise::pdc_freeze() semantic change 3/7: add freeze()/thaw() to old EH LLDDs 4/7: use freeze()/thaw() for polling PIO 5/7: integrate freeze/thaw with irq_on/off 6/7: tf_load() cleanup 7/7: remove ap->last_ctl - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html