Re: CHRP PCI fixup for Pegasos IDE (looking for testers)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Fixed the define thing.

As a corollary to the patch it might be a good idea to fix the
arch/powerpc/kernel/prom_init.c at line ~2084 and remove the
interrupt 15 reference

		prop[0] = 14;
		prop[1] = 0x0;
-		prop[0] = 15;
-		prop[1] = 0x0;
-		prom_setprop(ph, name, "interrupts", prop, 4*sizeof(u32));
+		prom_setprop(ph, name, "interrupts", prop, 2*sizeof(u32));
	}
}

Since nobody uses the device tree for anything here, I think
it's merely cosmetic, though.

I'll see what I can do about getting this fix into the firmware
as and if the via86cxxx driver works with it (I have my doubts but
am willing to be pleasantly surprised)

-- 
Matt Sealey <matt@xxxxxxxxxxxxxx>
Genesi, Manager, Developer Relations

Alan Cox wrote:
>> I don't understand what you mean by the ifdef being wrong. I don't
>> see how else I can make any kind of check for it. If the fix needs
> 
> if defined(CONFIG_FOO) || defined(CONFIG_FOO_MODULE)
> 
>> The viaide->irq check is just me being careful. I know for a fact the
>> only way the Pegasos is set up on every firmware revision is that
>> the PCI interrupt line for the IDE controller is set to 14. If it's
> 
> Cool. Thats fine then.
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux