Jeff Garzik wrote:
Mark Lord wrote:
....
+ if (scsi_op == ATA_16 && dev->class == ATA_DEV_ATAPI && !ata16_passthru)+ max_len = 16; + else + max_len = dev->cdb_len; + + if (unlikely(!scmd->cmd_len || scmd->cmd_len > max_len)) { + DPRINTK("bad CDB len=%u, max=%u\n", + scmd->cmd_len, max_len);looks like a chompified patch (double '+')
Yup. Chompified. There used to be a blank line above that one. I must have hit enter or something while editing the email. Will resend. ...
+ xlat_func = ata_get_xlat_func(dev, scsi_op); + if (xlat_func) + rc = ata_scsi_translate(dev, scmd, done, xlat_func); + else + ata_scsi_simulate(dev, scmd, done); return rc;this looks like a bug? ata_scsi_simulate() should not be called for ATAPI devices.
Notabug. ata_get_xlat_func will always return either atapi_xlat or ata_scsi_pass_thru for ATAPI devices. Cheers - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
