On Mon, 29 Jan 2007, Mike Christie wrote: > > Actually, I do not think we did this in 2.6.19. Tomo added a bug when he > ported a patch and mixed up some things so we did something weird for > 2.6.20-rc1. Ah, ok. Warring bugs. Have you pinpointed the original one? Is it your original "block: support larger block pc requests" after all? It looks like yours is the one that did the big changes, with Tomo then fixing some of the fallout? In fact, now that I look closer, I see that it's definitely your first patch that first removes the old code: > In 2.6.19, we did: > > bio = rq->bio; > blk_execute_rq() <- the execution sets rq->bio to null so that is why we > save a bio pointer. > blk_rq_unmap_user(bio); And then your patch introduces the bug: > For a while in 2.6.20-rc1, we basically did > > blk_execute_rq() > blk_rq_unmap_user(rq->bio) <- this was a bug that caused the mem leak > and caused data to not be copied because rq->bio was null. .. and perhaps introduced somethign else too? and thus: > Tomo and Jens then fixes this in 2.6.20-rc2 or rc3 to what we have in rc6: > > bio = rq->bio; > blk_execute_rq() <- the execution sets rq->bio to null so that is why we > save a bio pointer. > blk_rq_unmap_user(bio); didn't actually help, because if fixed the bio leak, but it didn't fix whatever else went wrong.. Mike, with (a) you being attributed as the author of that original "support larger block pc requests" and (b) Jens apparently off gallivating somewhere, I really hope we you can find this, because otherwise I get the feeling that I have to revert that series if I'm to release a 2.6.20 in any kind of timely manner. (Not that I haven't held up releases before, but this seems to be the main remaining thing, and in that light I think I'd probably end up reverting..) No pressure ;) (But it certainly doesn't have to be "today", so don't take it that way) Linus - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
