Alan wrote:
If the shared code is tiny, just create a header file and #include it
(sata_promise and sata_sx4 do this). Otherwise, create a shared library
module.
pata_sis is both the SiS driver and the shared library. What needs fixing
It is /very/ bad policy to force the user to load a driver that drives
real hardware, just to be able to access a few functions. Hardware and
probe side effects are a very real possibility, and with this setup, the
user has /less/ control than normal over things such as load order when
pata_sis is loaded as a dependency.
If the duplicated code in question is small, just putting it in a header
file a la drivers/ata/sata_promise.h is fine. Otherwise, a library
approach with no side effects should be chosen.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
