Re: [PATCH 2.6.20-rc3-mm1 2/2] libata: SiS 180 pata/sata support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Uwe Koziolek wrote:
This patch includes the PATA support for SiS180 importing PATA functionality from pata_sis.c

Signed-off-by: Uwe Koziolek <uwe.koziolek@xxxxxxx>

--- a/drivers/ata/sata_sis.c	2007-01-07 20:54:38.000000000 +0100
+++ b/drivers/ata/sata_sis.c	2007-01-07 23:42:29.000000000 +0100
@@ -138,6 +138,10 @@
 	.port_ops	= &sis_ops,
 };
+#ifdef CONFIG_PATA_SIS
+extern struct ata_port_info sis_info133;
+#endif

This is a poor way to share code between modules. It fails when pata_sis is a module, and it forces another driver to be loaded, simply then to be used as a code library.

If the shared code is tiny, just create a header file and #include it (sata_promise and sata_sx4 do this). Otherwise, create a shared library module.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux