Jeff Garzik wrote: > Tejun Heo wrote: >> 'hdparm -I' doesn't work with ATAPI devices and sg_sat is not widely >> spread yet leaving no easy way to access ATAPI IDENTIFY data. >> Implement HDIO_GET_IDENTITY such that at least 'hdparm -i' works. >> >> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> > > Are you certain this works for both big-endian and little-endian? > > A quick "it works" test by somebody on sata_svw (ppc64) or another > big-endian platform would be nice. I think it does. What the code does is identical to what drivers/ide does. Anyways, it doesn't really matter, I think we should drop this patch (3/3 only, that is). The reason why I implemented this was to get ATAPI ID data using 'hdparm -i' but as Mark Lord pointed out, 'hdparm -I' can do IDENTIFY PACKET DEVICE if the kernel is fixed. I think that's the way to go. Thanks. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
