> > For 16 byte commands via SG_IO you know the command is 16 bytes long as > > the command length is passed in hdr->cmd_len which becomes rq->cmd_len. > > Is that not sufficient to avoid this ATA_16 test if you pass it on to the > > required functions ? > > No. The SCSI code calculates the expected cmd_len based on the opcode it sees, > and makes exceptions only for the vendor-specific command blocks, > which ATA_16 is *not* part of. I know it currently does this, the more important question for the ATA side is - should it ? - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html