Alan Cox wrote:
Ar Sul, 2006-08-06 am 23:41 +0900, ysgrifennodd Tejun Heo:
I see. I have a question though. ATM, there are a few drives in the
current #upstream which deal with PATA devices (ata_piix, pdc_adma and
sata_promise). Will they all act correctly without the above logic? If
so, I'll drop the above part and regenerate the tree. If not, it can
stay till those drivers are patched.
I went through them checking earlier. The majority of chipsets snoop the
drive select bit and will generate appropriate cycles by device
according to that bit. Not everything does but I have been through and
made sure the ones that don't correctly merge timings. At least I hope I
have them all anyway.
I'm sure you've got them all correct in #pata-drivers :) but what I was
worried about was whether the drivers in libata-dev#upstream are ready
because, if not, those timing merge bits should be merged into #upstream
first. Hmmm... Diffing pata-drivers and upstream... Only ata_piix has
set_piomode() update in #pata-drivers. Can you please check whether
ata_piix in #upstream will be safe?
Thanks.
--
tejun
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
