Ar Sad, 2006-08-05 am 06:01 +0900, ysgrifennodd Tejun Heo: > + /* Use the lowest common PIO mode to avoid violating device > + * selection timing. > + */ > + for (i = 0; i < ATA_MAX_DEVICES; i++) { > + struct ata_device *d = &ap->device[i]; > + if (!ata_dev_absent(d)) > + xfer_mask &= ata_pack_xfermask(d->pio_mask, > + UINT_MAX, UINT_MAX); > } We should not do this. Many of the controllers are smart enough to get it right and those which do not implement this logic internally and correctly by merging the relevant fields in the ata timing structure. Alan - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html