zhao, forrest wrote:
According to ACPI spec 3.0, _GTM and _STM are IDE-only objects, _SDD is SATA-only object. And in your patch you used field "legacy_mode" of "struct ata_probe_ent" in order to distinguish between IDE and SATA. But after reading the code of ata_pci_init_one(), I found that "legacy_mode" is used to distinguish between legacy mode and native PCI mode of IDE controller. Am I right? Or did I miss anything? If I'm right, I'll fix it during the porting of your patch.
You are correct, you should use cbl==SATA or ATA_FLAG_SATA to check for SATA. legacy-vs-native is not an accurate check.
Jeff - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
