On Wed, 2006-06-14 at 08:19 -0700, Randy.Dunlap wrote: > On Wed, 14 Jun 2006 16:01:54 +0800 zhao, forrest wrote: > > > On Thu, 2006-06-08 at 23:11 -0400, Jeff Garzik wrote: > > > Forrest, > > > > > > BTW, if you are looking for useful libata projects, it would really be > > > nice to resurrect Randy Dunlap's SATA ACPI patches, update those for the > > > current libata-dev.git#upstream, and get those in. > > > > Randy, > > > > Could you confirm if your latest SATA-ACPI patch is at this URL? > > http://www.xenotime.net/linux/SATA/2.6.16-rc4/libata-rollup-2616-rc4.patch > > Yes, correct. According to ACPI spec 3.0, _GTM and _STM are IDE-only objects, _SDD is SATA-only object. And in your patch you used field "legacy_mode" of "struct ata_probe_ent" in order to distinguish between IDE and SATA. But after reading the code of ata_pci_init_one(), I found that "legacy_mode" is used to distinguish between legacy mode and native PCI mode of IDE controller. Am I right? Or did I miss anything? If I'm right, I'll fix it during the porting of your patch. Thanks, Forrest - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
