>> +static struct ata_device * ata_find_dev(struct ata_port *ap, int id)
>> +{
>> + if (likely(id == 0 || (id == 1 && ap->flags & ATA_FLAG_SLAVE_POSS)))
>> + return &ap->device[id];
>> + return NULL;
>> +}
>> +
>
>>From my understanding, the definition of function ata_find_dev() should
> be in libata-core.c instead of libata-scsi.c. Does it make sense to you?
Could be. However, as it's currently used only inside libata-scsi.c, I
think we can leave it as static function for the time being.
--
tejun
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
