Linus Torvalds wrote:
On Sat, 27 May 2006, Linus Torvalds wrote:
Objections? Can everybody confirm that a clean current git tree with just
this doesnt' have any huge downsides?
Perhaps more importantly, can anybody imagine any realistic possible
downsides at all? Both waits have an _eventual_ timeout (although the busy
wait is pretty damn long), so even the most perverse controller should at
worst just wait a fairly long time.
And we're doing nothing but reading the status register, so I don't see
any reasonable breakage.
Well,
* The second wait is pointless, but harmless
* Modern FIS-based controllers (ahci, sata_sil24, SAS HBAs) don't poll
for BSY, ATA is completely packetized and different. But still
harmless, since only ata_piix suspends. The code must go elsewhere,
when other controllers start suspending.
Thus, no objections for 2.6.17.
Jeff
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
