Jeff Garzik wrote:
Tejun Heo wrote:
Make ata_drive_probe_reset() use SATA SPD configuration. Hardreset
will be force if speed renegotiation is necessary. Also, if a
hardreset fails, PHY speed is stepped down and hardreset is retried
until the lowest speed is reached.
Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
Tentative ACK: I wonder if a naked COMRESET is the best procedure for
changing PHY speeds. We might even power down the phy, change speeds,
and then power it up again. Need to reach my SATA docs, and maybe talk
to some device/controller vendors.
AFAICS, SATA doc doesn't say anything about how to change PHY speed.
FYI, ICH7 AHCI works fine with the current implementation.
I'm a bit skeptical about doing naked COMRESET from libata core layer. I
think the right direction is to make SATA spd configuration the
responsibility of hardreset operation.
--
tejun
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
