Re: [PATCH 13/15] libata: add 1s sleep between resets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Garzik wrote:
Tejun Heo wrote:
Some devices react badly if resets are performed back-to-back.  Give
devices some time to breath.

Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>

---

 drivers/scsi/libata-core.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

e7f505c001fd4cb43b8123387285a7694790b4ae
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index 30ee203..bd9ca3b 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -2633,6 +2633,7 @@ int ata_drive_probe_reset(struct ata_por
         rc = ata_do_reset(ap, softreset, postreset, 0, classes);
         if (rc == 0 && classes[0] != ATA_DEV_UNKNOWN)
             goto done;
+        ssleep(1);
     }
if (!hardreset)
@@ -2649,6 +2650,7 @@ int ata_drive_probe_reset(struct ata_por
if (ata_down_sata_spd_limit(ap, &ap->device[0]))
             goto done;
+        ssleep(1);

My gut says it should be at least 5 seconds...


Okay. And I'll add a little message such that the user staring at the console doesn't get bored during that 5 secs.

--
tejun
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux