Re: [PATCH 01/41] drivers: tty: serial: dz: use dev_err() instead of printk()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH 01/41] drivers: tty: serial: dz: use dev_err() instead of printk()
- From: "Maciej W. Rozycki" <macro@xxxxxxxxxxxxxx>
- Date: Wed, 1 May 2019 03:20:37 +0100 (BST)
- Cc: "Enrico Weigelt, metux IT consult" <lkml@xxxxxxxxx>, "Enrico Weigelt, metux IT consult" <info@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, andrew@xxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, vz@xxxxxxxxx, slemieux.tyco@xxxxxxxxx, khilman@xxxxxxxxxxxx, liviu.dudau@xxxxxxx, sudeep.holla@xxxxxxx, lorenzo.pieralisi@xxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, jacmet@xxxxxxxxxx, linux@xxxxxxxxxxxxxxx, matthias.bgg@xxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx
- In-reply-to: <20190429131224.GA27385@kroah.com>
- References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-2-git-send-email-info@metux.net> <20190427133117.GC11368@kroah.com> <bae3f23b-8823-f089-c40e-024ba225555f@metux.net> <20190429131224.GA27385@kroah.com>
- User-agent: Alpine 2.21 (LFD 202 2017-01-01)
On Mon, 29 Apr 2019, Greg KH wrote:
> > >> drivers/tty/serial/dz.c | 8 ++++----
> > >
> > > Do you have this hardware to test any of these changes with?
> >
> > Unfortunately not :(
>
> Then I can take the "basic" types of patches for the driver (like this
> one), but not any others, sorry.
I can verify changes to dz.c, sb1250-duart.c and zs.c with real hardware,
but regrettably not right away: the hardware is in a remote location and
while I have it wired for remote operation unfortunately its connectivity
has been cut off by an unfriendly ISP.
I'm not sure if all the changes make sense though: if there is a compiler
warning or a usability issue, then a patch is surely welcome, otherwise:
"If it ain't broke, don't fix it".
Maciej
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]