serial drivers polishing
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: linux-kernel@xxxxxxxxxxxxxxx
- Subject: serial drivers polishing
- From: "Enrico Weigelt, metux IT consult" <info@xxxxxxxxx>
- Date: Sat, 27 Apr 2019 14:51:41 +0200
- Cc: gregkh@xxxxxxxxxxxxxxxxxxx, andrew@xxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, macro@xxxxxxxxxxxxxx, vz@xxxxxxxxx, slemieux.tyco@xxxxxxxxx, khilman@xxxxxxxxxxxx, liviu.dudau@xxxxxxx, sudeep.holla@xxxxxxx, lorenzo.pieralisi@xxxxxxx, davem@xxxxxxxxxxxxx, jacmet@xxxxxxxxxx, linux@xxxxxxxxxxxxxxx, matthias.bgg@xxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx
Hello folks,
here's another attempt of polishing the serial drivers:
* lots of minor cleanups to make checkpatch happier
(eg. formatting, includes, inttypes, ...)
* use appropriate logging helpers instead of printk()
* consequent use of mapsize/mapbase fields:
the basic idea is, all drivers should fill mapbase/mapbase fields at
init time and later only use those fields, instead of hardcoded values
(later on, we can add generic helpers for the map/unmap stuff, etc)
* untwisting serial8250_port_size() at all:
move the iomem size probing to initialization time, move out some
platform specific magic to corresponding platform code, etc.
Unfortunately, I don't have the actual hardware to really test all
the code, so please let me know if there's something broken in here.
have fun,
--mtx
- Follow-Ups:
- Re: serial drivers polishing
- [PATCH 05/41] drivers: tty: serial: dz: use pr_info() instead of incomplete printk()
- From: Enrico Weigelt, metux IT consult
- [PATCH 10/41] drivers: tty: serial: sb1250-duart: fix missing parentheses
- From: Enrico Weigelt, metux IT consult
- [PATCH 14/41] drivers: tty: serial: uartlite: remove unnecessary braces
- From: Enrico Weigelt, metux IT consult
- [PATCH 01/41] drivers: tty: serial: dz: use dev_err() instead of printk()
- From: Enrico Weigelt, metux IT consult
- [PATCH 12/41] drivers: tty: serial: uartlite: use dev_dbg() instead of pr_debug()
- From: Enrico Weigelt, metux IT consult
- [PATCH 07/41] drivers: tty: serial: sb1250-duart: include <linux/io.h> instead of <asm/io.h>
- From: Enrico Weigelt, metux IT consult
- [PATCH 13/41] drivers: tty: serial: uartlite: fill mapsize and use it
- From: Enrico Weigelt, metux IT consult
- [PATCH 02/41] drivers: tty: serial: dz: include <linux/io.h> instead of <asm/io.h>
- From: Enrico Weigelt, metux IT consult
- [PATCH 16/41] drivers: tty: serial: uartlite: fix overlong lines
- From: Enrico Weigelt, metux IT consult
- [PATCH 08/41] drivers: tty: serial: sb1250-duart: fix checkpatch warning on printk()
- From: Enrico Weigelt, metux IT consult
- [PATCH 18/41] drivers: tty: serial: apbuart: use dev_info() instead of printk()
- From: Enrico Weigelt, metux IT consult
- [PATCH 15/41] drivers: tty: serial: uartlite: fix use fix bare 'unsigned'
- From: Enrico Weigelt, metux IT consult
- [PATCH 04/41] drivers: tty: serial: dz: fix use fix bare 'unsigned'
- From: Enrico Weigelt, metux IT consult
- [PATCH 21/41] drivers: tty: serial: cpm_uart: fix includes
- From: Enrico Weigelt, metux IT consult
- [PATCH 19/41] drivers: tty: serial: apbuart: fix code formatting
- From: Enrico Weigelt, metux IT consult
- [PATCH 17/41] drivers: tty: serial: apbuart: fix logging calls
- From: Enrico Weigelt, metux IT consult
- [PATCH 22/41] drivers: tty: serial: cpm_uart: fix logging calls
- From: Enrico Weigelt, metux IT consult
- [PATCH 20/41] drivers: tty: serial: cpm_uart: use dev_err()/dev_warn() instead of printk()
- From: Enrico Weigelt, metux IT consult
- [PATCH 25/41] drivers: tty: serial: timbuart: fix formatting issues
- From: Enrico Weigelt, metux IT consult
- [PATCH 28/41] drivers: tty: serial: sunzilog: fix includes
- From: Enrico Weigelt, metux IT consult
- [PATCH 32/41] drivers: tty: serial: 21285: define's for address/size, use mapsize field
- From: Enrico Weigelt, metux IT consult
- [PATCH 23/41] drivers: tty: serial: cpm_uart: fix styling issues
- From: Enrico Weigelt, metux IT consult
- [PATCH 27/41] drivers: tty: serial: sunzilog: fix formatting issues
- From: Enrico Weigelt, metux IT consult
- [PATCH 33/41] drivers: tty: serial: zs: use dev_err() instead of printk()
- From: Enrico Weigelt, metux IT consult
- [PATCH 03/41] drivers: tty: serial: dz: fix missing parentheses
- From: Enrico Weigelt, metux IT consult
- [PATCH 29/41] drivers: tty: serial: sunzilog: cleanup logging
- From: Enrico Weigelt, metux IT consult
- [PATCH 30/41] drivers: tty: serial: ioc4_serial: use dev_warn() instead of printk()
- From: Enrico Weigelt, metux IT consult
- [PATCH 26/41] drivers: tty: serial: sunzilog: use dev_info() instead of printk()
- From: Enrico Weigelt, metux IT consult
- [PATCH 24/41] drivers: tty: serial: timbuart: use dev_err() instead of printk()
- From: Enrico Weigelt, metux IT consult
- [PATCH 35/41] drivers: tty: serial: 8250: add mapsize to platform data
- From: Enrico Weigelt, metux IT consult
- [PATCH 36/41] drivers: tty: serial: 8250: store mmio resource size in port struct
- From: Enrico Weigelt, metux IT consult
- [PATCH 38/41] drivers: tty: serial: xilinx_uartps: fill mapsize and use it
- From: Enrico Weigelt, metux IT consult
- [PATCH 39/41] drivers: tty: serial: pmac_zilog: fill mapsize and use it
- From: Enrico Weigelt, metux IT consult
- [PATCH 41/41] drivers: tty: serial: lpc32xx_hs: fill mapsize and use it
- From: Enrico Weigelt, metux IT consult
- [PATCH 31/41] drivers: tty: serial: ioc4_serial: use pr_*() instead of printk()
- From: Enrico Weigelt, metux IT consult
- [PATCH 40/41] drivers: tty: serial: helper for setting mmio range
- From: Enrico Weigelt, metux IT consult
- [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation
- From: Enrico Weigelt, metux IT consult
- [PATCH 34/41] drivers: tty: serial: zs: fill mapsize and use it
- From: Enrico Weigelt, metux IT consult
- [PATCH 06/41] drivers: tty: serial: sb1250-duart: use dev_err() instead of printk()
- From: Enrico Weigelt, metux IT consult
- [PATCH 09/41] drivers: tty: serial: sb1250-duart: fill mapsize and use it
- From: Enrico Weigelt, metux IT consult
- [PATCH 11/41] drivers: tty: serial: sb1250-duart: fix formatting error
- From: Enrico Weigelt, metux IT consult
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]