Re: [PATCH 41/41] drivers: tty: serial: lpc32xx_hs: fill mapsize and use it
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: "Enrico Weigelt, metux IT consult" <info@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
- Subject: Re: [PATCH 41/41] drivers: tty: serial: lpc32xx_hs: fill mapsize and use it
- From: Vladimir Zapolskiy <vz@xxxxxxxxx>
- Date: Tue, 30 Apr 2019 23:52:58 +0300
- Cc: gregkh@xxxxxxxxxxxxxxxxxxx, andrew@xxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, macro@xxxxxxxxxxxxxx, slemieux.tyco@xxxxxxxxx, khilman@xxxxxxxxxxxx, liviu.dudau@xxxxxxx, sudeep.holla@xxxxxxx, lorenzo.pieralisi@xxxxxxx, davem@xxxxxxxxxxxxx, jacmet@xxxxxxxxxx, linux@xxxxxxxxxxxxxxx, matthias.bgg@xxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx
- In-reply-to: <1556369542-13247-42-git-send-email-info@metux.net>
- References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-42-git-send-email-info@metux.net>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
Hi Enrico,
On 04/27/2019 03:52 PM, Enrico Weigelt, metux IT consult wrote:
> Fill the struct uart_port->mapsize field and use it, insteaf of
typo, s/insteaf/instead/
> hardcoded values in many places. This makes the code layout a bit
> more consistent and easily allows using generic helpers for the
> io memory handling.
>
> Candidates for such helpers could be eg. the request+ioremap and
> iounmap+release combinations.
>
> Signed-off-by: Enrico Weigelt <info@xxxxxxxxx>
Acked-by: Vladimir Zapolskiy <vz@xxxxxxxxx>
--
Best wishes,
Vladimir
[Index of Archives]
[Linux Kernel]
[Sparc Linux]
[DCCP]
[Linux ARM]
[Yosemite News]
[Linux SCSI]
[Linux x86_64]
[Linux for Ham Radio]