On Thu, Mar 09, 2023 at 01:17:22PM +0200, Andy Shevchenko wrote: > On Thu, Mar 9, 2023 at 11:58 AM Uwe Kleine-König > <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > > > If pm runtime resume fails the .remove callback used to exit early. This > > resulted in an error message by the driver core but the device gets > > removed anyhow. This lets the registered i2c adapter stay around with an > > unbound parent device. > > > > So only skip clk disabling if resume failed, but do delete the adapter. > > Still worrisome. I would disable clock independently, but the questions are: Note that pm-runtime stuff disables the clk, so if resume failed, you have to assume the clk already being off. > 1) why the heck we need this dance with PM runtime for disabling clocks; > 2) why can't we use devm_clk_get_enabled() or so in the probe; These questions are orthogonal to my patch, right? Runtime PM might delay suspend, so if you submit two transfers shortly after another, this might be more effective as the device isn't suspended in between. (Attention: half-baked knowledge) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
