On Thu, Mar 9, 2023 at 11:58 AM Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > If pm runtime resume fails the .remove callback used to exit early. This > resulted in an error message by the driver core but the device gets > removed anyhow. This lets the registered i2c adapter stay around with an > unbound parent device. > > So only skip clk disabling if resume failed, but do delete the adapter. Still worrisome. I would disable clock independently, but the questions are: 1) why the heck we need this dance with PM runtime for disabling clocks; 2) why can't we use devm_clk_get_enabled() or so in the probe; ? -- With Best Regards, Andy Shevchenko
