Hi > -----Original Message----- > From: Wolfram Sang [mailto:wsa@xxxxxxxxxxxxx] > Sent: Friday, March 24, 2017 5:01 AM > To: Tan, Chin Yew <chin.yew.tan@xxxxxxxxx> > Cc: jarkko.nikula@xxxxxxxxxxxxxxx; andriy.shevchenko@xxxxxxxxxxxxxxx; > mika.westerberg@xxxxxxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] i2c: designware: Get selected speed mode sda-hold-time > via ACPI > > > > This describes why you change NULL to dev->sda_hold_time. But it > > doesn't say why you introduce the switch-block instead of populating > > all fields like it was done before. Instead of loading all speed mode settings, switch block is used to load the required settings for selected speed mode. Furthermore, using switch block re-use existing variable, Whereas, populating all fields introduce new variables. > > > > Furthermore, since now there is no NULL case for dw_i2c_acpi_params() > > anymore, we can remove NULL handling in that function, or? Ok, I will remove the null handling. > > And since designware driver had a few changes meanwhile, can you base the > next version on top of i2c/for-next? > Ok, I will base it to i2c/for-next. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
