On Tue, Feb 14, 2017 at 01:54:01PM +0800, chin.yew.tan@xxxxxxxxx wrote: > From: Tan Chin Yew <chin.yew.tan@xxxxxxxxx> > > Sda-hold-time is an important parameter for tuning i2c to meet the > electrical specification especially for high speed. I2C with incorrect > sda-hold-time may cause lost arbitration error. Now, the driver is able to > get sda-hold-time for all the speed supported. This describes why you change NULL to dev->sda_hold_time. But it doesn't say why you introduce the switch-block instead of populating all fields like it was done before. Furthermore, since now there is no NULL case for dw_i2c_acpi_params() anymore, we can remove NULL handling in that function, or?
Attachment:
signature.asc
Description: PGP signature
