On 05/26/2016 02:17 AM, Jean Delvare wrote:
Hi Corey,
snip
This is unfortunate because some of the changes would still be good to
have. In particular having a single call to i801_check_post() would be
a nice clean-up.
Yes, looking over this some more, several of the issues have been
addressed that these patches originally targeted.
This was originally part of a set of patches that allowed access to
I2C devices when the system couldn't schedule, primarily for
storing panic information and handling watchdogs at panic and
in kgdb. For that you have to event-drive it so you can poll.
I've abandoned those changes, but this small set looked
like it has some useful stuff.
Thanks for the review, I'll look at pulling out some of the good things
Thank you, I'll be happy to review and test the new series, hopefully
faster than I did for this one. Now that the i2c-i801 driver works on
my system again, it should be much easier.
Ok, thanks.
BTW, I have a working i801 device on qemu, if that helps you. I'm
working to get it into mainline there. What's in qemu now is only
marginally functional.
(and getting rid of hwpec from i801_block_transaction_byte_by_byte
since it's not used there any more).
Did it ever work? And more importantly, does the hardware support it?
Before cleaning up the code, I'd like to make sure the driver supports
PEC in all cases where the hardware itself supports it. I'll do some
tests.
The docs are kind of unclear. I didn't find anything that said it
didn't work, but I got that impression from some place. I never
tested it out.
-corey
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
