Hi Corey, On Tue, 19 Jan 2016 11:09:37 -0600, minyard@xxxxxxx wrote: > From: Corey Minyard <cminyard@xxxxxxxxxx> > > There was a lot of redundant code in the driver, basically one copy > for the polled interface and one for the interrupt-driven interface. > Only use the interrupt-driven interface and use a timer to check > the interface periodically and time things out. This patch is simply too large and messy for me to consider reviewing it. It needs to be split into smaller pieces. But honestly I don't see that much redundancy in the driver, and as a matter of fact your patch adds more lines than it removes. This is unfortunate because some of the changes would still be good to have. In particular having a single call to i801_check_post() would be a nice clean-up. > This also adds timeouts when using interrupt, so a failed operation > won't hang forever. As far as I can see, the current code already has these timeouts, although maybe it wasn't the case when you first wrote this patch? This was added by b3b8df9772 in November 2014. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
